Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes and cleanup #225

Merged
merged 55 commits into from
Aug 9, 2024
Merged

Bug fixes and cleanup #225

merged 55 commits into from
Aug 9, 2024

Conversation

mlwilkerson
Copy link
Member

@mlwilkerson mlwilkerson commented Aug 9, 2024 •
edited
Loading

  • clean up querying for the icon chooser
  • improve icon chooser query caching
  • clear icon chooser query cache when updating kits data on the plugin settings page
  • make access token handling more robust, with possible automatic refresh
  • add error handling and custom exceptions with user-facing language when setting up self-hosting for SVG styles
  • change when block editor assets are enqueued, resolving problem with the lodash/_ global causing problems for other plugins
  • change height of block styling modal to fully contain the custom color picker when screens are tall enough

@mlwilkerson
wire-up faApiUrl to front end for icon chooser
f95729f 
- also, auto-formatting
@mlwilkerson
refactor queryCache
837793c
@mlwilkerson
refactor building prefixed keys
fdd726d
@mlwilkerson
implement clearQueryCache()
ab6646e
@mlwilkerson
run clearQueryCache() when fetching kits data
f673eab
@mlwilkerson
remove console log
1f2da08
@mlwilkerson
make access token refresh more robust
b60cee6
@mlwilkerson
refactor access token getter code
4ee289f
@mlwilkerson
ignore .zed project settings
288a1fd
@mlwilkerson
add comments
94a8e74
@mlwilkerson
remove unused
adcfaec
@mlwilkerson
update phpactor exclusions
90b3b82
@mlwilkerson
auto-formatting
e470740
@mlwilkerson
sniff fixes
31a4986
@mlwilkerson
update phpactor config
d07a14f
@mlwilkerson
add return type
b66abba
@mlwilkerson
adding some more return types
252b3e2
@mlwilkerson
update doc
2a0856f
@mlwilkerson
throw NoAccessTokenException
e78728f
@mlwilkerson
indicate internal-onlyuse
7b7f8a7
@mlwilkerson
remove obsolete code
191c5fc
@mlwilkerson
improve classic editor TinyMCE plugin, toward 1:1 relationship betwee…
b7f0cf5 
…n icon chooser and TinyMCE instance
@mlwilkerson
remove obsolete injection of icon chooser container div for classic e…
d6a78c5 
…ditor
@mlwilkerson
update plugin-nu description and version
24dc3b3
@mlwilkerson
disable phpactor phpcs
ada03b1
@mlwilkerson
distinguish between TinyMCE editors by editor_id
b7dbbea
@mlwilkerson
increase height of property section on style modal to better fit cust…
56a88e7 
…om color picker

...and auto-formatting
@mlwilkerson
initial re-write of self-hosting exception messages.
75a389a
@mlwilkerson
include missing algo name in exception message
f36f7ef
@mlwilkerson
auto-formatting and cleaning
f5e61f2
@mlwilkerson
update all JS bundles to use lodash-es deep imports to avoid overwrit…
aee49af 
…ing global lodash
@mlwilkerson
rebuild block-editor bundle
8808fc9
@mlwilkerson
rebuild classic-editor bundle
5a96a57
@mlwilkerson
rebuild icon-chooser bundle
f1069a8
@mlwilkerson
rebuild admin bundle
2f2a848
@mlwilkerson
auto-formatting
947494e
@mlwilkerson
update more admin bundle lodash exports to use lodash-es
fcd9e56
@mlwilkerson
rebuild admin bundle
4dfaa8e
@mlwilkerson
change the timing of when to load block assets
9185fb2 
solves the problem with the global lodash _ being reset to undefined
@mlwilkerson
rearrange
af20177
@mlwilkerson
auto-formatting
2230aca
@mlwilkerson
manual formatting of doc comments
7754905
@mlwilkerson
add block_init.php to phpcs config
9de2572
@mlwilkerson
add back a missing lodash has import
e306e6c
@mlwilkerson
rebuild admin bundle
e9e433b
@mlwilkerson
in admin bundle, migrate to using the lodash that ships with WordPress
06f582b
@mlwilkerson
update block-editor to use the WordPress built-in lodash
968b26f
@mlwilkerson
rebuild admin bundle
5d12788
@mlwilkerson
use WP built-in lodash for icon-chooser bundle
60fdc36
@mlwilkerson
use WP built-in lodash for classic-editor bundle
68b7339
@mlwilkerson
make the retrieval of an access token conditional on using a kit
ad1809d
@mlwilkerson
rebuild icon-chooser bundle
14991cf
@mlwilkerson
remove custom fixups for globals like lodash and moment
df8e4fb 
now that we're using @wordpress/scripts more conventionally, we can rely
on those to externalize such libraries and ensure that our bundles don't
load conflicting globals
@mlwilkerson
WIP: fixing up phpcs errors and warnings
191cc12
@mlwilkerson
rename block init file to satisfy phpcs
1492ff7
@mlwilkerson mlwilkerson merged commit 1a07d19 into epic/v5 Aug 9, 2024
1 check passed
@mlwilkerson mlwilkerson deleted the v5/refine-icon-chooser-support branch August 9, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mlwilkerson