Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make possible to use size in percentage #77

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Strate
Copy link

@Strate Strate commented Nov 25, 2020

Hello.
It is actually works (I can specify size in percentage for react-native-svg component), but emits warning. This PR removes that warning and allows to specify icon size in percentage

Hello.
It is actually works (I can specify size in percentage for react-native-svg component), but emits warning. This PR removes that warning and allows to specify icon size in percentage
@robmadole
Copy link
Member

@Strate can you speak more about why you needed percentage? This has me scratching my head a bit. I'm not against percentage but I'd like to understand it first.

@sam3d
Copy link

sam3d commented Jun 19, 2022

@robmadole I would also really benefit from this!

For example, I have a grid of icons that scale with the device size (i.e. each icon is 1/4 of the device width) and ideally being able to set the icons to automatically adopt that width instead of being limited to a specific number would make that much easier to accomplish.

This is likely fairly common with mobile devices, where many slightly different screen sizes could affect this functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants