Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated String.prototype.substr() #119

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace deprecated String.prototype.substr() #119

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61b9dac
Replace deprecated String.prototype.substr()
CommanderRoot Apr 5, 2022
75cd0d4
Merge branch 'master' into refactor/rm-deprecated-substr
CommanderRoot Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Replace deprecated String.prototype.substr() 
.substr() is deprecated so we replace it with functions which work similarily but aren't deprecated

Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
  • Loading branch information
@CommanderRoot
CommanderRoot committed Apr 5, 2022
commit 61b9dac0296b941696b7ca4a5c21ceb5c86857ea
2 changes: 1 addition & 1 deletion src/components/__tests__/FontAwesomeIcon.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function rgbToHex(r, g, b) {
}

function decimalToHex(decimal) {
return decimal.toString(16).substr(2, 6);
return decimal.toString(16).slice(2, 8);
}

// react-native-svg changed the way it uses the `fill` attribute across versions. Older versions
Expand Down