Reduce bundle size by removing runtime props validation #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmadole
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as I suggested in #232 we can reduce lib bundle size by removing runtime checks of
prop-typesand rely on TypeScript to do build time checksi really would like to get a feedback on this idea from repo maintainers, so I decided to create PR before getting a green light for it in the issue. I hope its ok and isn't considered PR spam as I didn't intend for it
Anyway thank you for your work regardless if this PR gets approved or cancelled
UPD: as of this article even without bundle size thing
prop-typesare deprecated as of 2017 and its errors will be silently ignored starting from React 19, so more reasons to strip this dep offhttps://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops