Release Font Awesome Free 6.0.0 #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpoiry
reviewed
Mar 8, 2022
alexpoiry
reviewed
Mar 8, 2022
alexpoiry
reviewed
Mar 8, 2022
There was a problem hiding this comment.
It seems pretty straight-forward and simple to use. Documentation is pretty clear. It is hard to say if it is complete unless I actually try them. I suppose if I REALLY wanted to make sure it was good I'd try to setup a quick Ruby on Rails Hello World app and see if I could add the items per your instructions.
alexpoiry
reviewed
Mar 9, 2022
There was a problem hiding this comment.
I don't think this is entirely accurate:
If app/assets/stylesheets/application.css.scss does not exist then rename app/assets/stylesheets/application.css and add the @import statements below the *= require statements but outside of the comment block.
I had to add the sass gem and run bundler install. Might be worth pointing that out.
robmadole
reviewed
Mar 9, 2022
supercodepoet
force-pushed
the
v6.0.0-wip
branch
from
ebe9615
to
a869ecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.