-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use font-url path for proper asset compiling #20
Conversation
Use font-url path for proper asset compiling
This fixes the problem with asset compiling, but breaks URLs for applications deployed under a subdirectoy. For example, this is the path to my compiled application.css file:
within
which gets a 404 error because its not within the parent |
@lightswitch05 The |
@brianpattison - I believe that this would be a valid work-around. However, all my other assets (css, js, png, etc) are able to load correctly without setting the relative root param. Since my root is variable (based on the name of the war file), I would really hate to limit the path to a static name, especially since I regularly deploy different versions of the app to the same server for testing purposes. Perhaps this is a bug in warbler for fonts. |
@lightswitch05 I wasn't trying to give you a work-around. I was trying to point you toward the proper solution. Asset Pipeline is generating the URL, so your issue is not with this gem but instead with how asset pipeline is generating the URLs for your Rails app. The font-awesome-sass gem is simply using your configuration for the asset pipeline. |
@brianpattison thank you for trying to point me in the right direction. Setting the |
@lightswitch05 Glad figured out a solution. The reason that I feel like there's a better solution to your problem than what you're doing, but I honestly don't know what it is. The asset pipeline is kind of crazy. :) |
@brianpattison - I ended up removing my hack because it wasn't actually working. I added: The problem is that I'm deploying on a java server using jRuby. a I don't think forcing I don't know what the best solution for this is. Perhaps we could change it to be a relative URL and then add a sass variable to adjust that relative path for anyone who has it installed in a strange location. I don't know how to make use of the asset pipeline while keeping it a relative path. |
font-url
should be used so that the Asset Pipeline can point to the compiled version of the font.