Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ember-get-config #207

Merged
merged 1 commit into from
May 6, 2022
Merged

Conversation

mansona
Copy link
Contributor

@mansona mansona commented May 6, 2022

I recently hit the same error that we see in #205 where you get the dreaded:

[Embroider:MacrosConfig] the given config from '/Users/me/Projects/ember-foo/node_modules/ember-get-config' for packageName 'undefined' is not JSON serializable.

when you try to build app. This makes total sense considering what EmbrioiderMacros does but I recently released a version of ember-get-config (I'm the maintainer 😂) that fixes this problem because it doesn't serialize the config anymore 👍

This PR upgrades ember-get-config to that new version 🎉

@jrjohnson jrjohnson merged commit 0c7fec1 into FortAwesome:master May 6, 2022
@mkszepp
Copy link
Contributor

mkszepp commented Jun 24, 2022

@jrjohnson this change was braking in 0.3.3, when a other package is using 1.0.0 the update is not possible. Maybe it shoud be reverted in 0.3.x and readded in 0.4.x

The other possiblity would be to add in dependency: "ember-get-config": "^1.0.1 || ^2.0.0", so there is not beaking

@robmadole
Copy link
Member

robmadole commented Jun 24, 2022

I'm chatted with @jrjohnson on this and I'll be releasing 0.4.0 and deprecating 0.3.3 here in just a bit.

@robmadole
Copy link
Member

Ok. 0.3.3 is deprecated and a 0.4.0 and 0.3.4 (without ember-get-config@2.x dependency) are released.

Let me know if this is still causing pain!

@mkszepp
Copy link
Contributor

mkszepp commented Jun 27, 2022

@robmadole thank for the revert, confirm that there is now possibile the update to 0.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants