Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pause in MUTATION_OBSERVER with config.observeMutations #15859

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TurboControl
Copy link

config.observeMutations is only checked before the MUTATION_OBSERVER is created, but I need this check at runtime when the DOM is too busy. The disable function isn't exposed to an interface. unwatch() is also not available. This was the simplest change.

This change allows the DOM.watch() to be paused in cases that could cause an out of memory error.
Issue link:
#15858

I understand that:

  • I'm submitting this PR for reference only. It shows an example of what I'd like to see changed but
    I understand that it will not be merged and I will not be listed as a contributor on this project.

…isn't ready and runs to an out of memory error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant