Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Awesome Documention descibes ability to pass parameters to the d… #15639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rwilson504
Copy link

Font Awesome document states that the dom.watch() interface allows for parameters to be passed to limit the scope of the watch yes these paramereters are not defined in the interface.
https://fontawesome.com/how-to-use/with-the-api/methods/dom-watch

I understand that:

  • I'm submitting this PR for reference only. It shows an example of what I'd like to see changed but
    I understand that it will not be merged and I will not be listed as a contributor on this project.

…om.watch() function yet when attemping this the paramereters are not defined in the interface.
@tagliala tagliala requested review from robmadole and removed request for robmadole October 2, 2019 06:16
@tagliala
Copy link
Member

tagliala commented Oct 2, 2019

Hi!

Thanks for being part of the Font Awesome Community and thanks for this PR.

Let's assign @robmadole and @mlwilkerson

@jogibear9988
Copy link

in my pull request #19301 I've made both parameters optional. Don't know if this is allowed to pass only one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants