Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definitions for DOM interface #14586

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix definitions for DOM interface #14586

wants to merge 1 commit into from

Conversation

danjohnso
Copy link

@danjohnso danjohnso commented Jan 31, 2019

DOM interfaces were off slightly from published API. Adjusted them so TS users can use accurately

I understand that:

  • I'm submitting this PR for reference only. It shows an example of what I'd like to see changed but
    I understand that it will not be merged and I will not be listed as a contributor on this project.

DOM interfaces were off slightly from published API.  Adjusted them so TS users can use accurately
@danjohnso
Copy link
Author

I am a typescript user and looking to use some of the SVG APIs in my project. I noticed the definitions are off from your actual API. I didn't review all of your interfaces, but DOM ones were quick fixes since I need them in m y project. I am shimming my project with these definitions, but thoughts others may end up in the same boat.

@tagliala
Copy link
Member

tagliala commented Feb 1, 2019

Hi!

Thanks for this PR.

I've assigned @mlwilkerson so he can take a look

@danjohnso
Copy link
Author

Any chance this is going to get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants