Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i2svg options should be optional #14512

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

i2svg options should be optional #14512

wants to merge 2 commits into from

Conversation

cooljeffro
Copy link

@cooljeffro cooljeffro commented Jan 17, 2019

In i2svg, when specifying the 'node' param, typescript then requires the 'callback' param. Both 'node' and 'callback' should be optional.

I understand that:

  • I'm submitting this PR for reference only. It shows an example of what I'd like to see changed but
    I understand that it will not be merged and I will not be listed as a contributor on this project.

In i2svg, when specifying the 'node' param, typescript then requires the 'callback' param. Both 'node' and 'param' should be optional.
@tagliala
Copy link
Member

@mlwilkerson could you please take a look here?

@mlwilkerson
Copy link
Member

Thanks @cooljeffro and @tagliala . This looks good to me and seems to bring the intended use of i2svg() in line with our own API doc examples.

I'll pass it along for possible inclusion in a future release of fontawesome-svg-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants