Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ordering to table and install snippets #13599

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ordering to table and install snippets #13599

wants to merge 2 commits into from

Conversation

fabricecolas
Copy link

@fabricecolas fabricecolas commented Jul 22, 2018 •
edited
Loading

I understand that:

  • I'm submitting this PR for reference only. It shows an example of what I'd like to see changed but
    I understand that it will not be merged and I will not be listed as a contributor on this project.

tagliala
tagliala reviewed Jul 22, 2018
View reviewed changes
UPGRADING.md Outdated
@fortawesome/free-solid-svg-icons \
@fortawesome/free-regular-svg-icons \
@fortawesome/free-brands-svg-icons
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a correct use case because you are adding to your node modules both svg and webfont versions

fabricecolas
fabricecolas commented Jul 22, 2018
View reviewed changes
Copy link
Author

@fabricecolas fabricecolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rm install snippet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tagliala tagliala tagliala left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabricecolas @tagliala