Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a structural loadparams! #1875

Merged
merged 19 commits into from
Apr 5, 2022
Merged

Add a structural loadparams! #1875

merged 19 commits into from
Apr 5, 2022

Commits on Apr 5, 2022

  1. Add initial implementation

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    cd06023 View commit details
    Browse the repository at this point in the history

  2. Add more tests

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    99a18ec View commit details
    Browse the repository at this point in the history

  3. Fix typo in tests

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    492c34e View commit details
    Browse the repository at this point in the history

  4. Refactor to allow better support for loading errors with custom models

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    dee5842 View commit details
    Browse the repository at this point in the history

  5. Add documentation for loadmodel!

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    b4fe66b View commit details
    Browse the repository at this point in the history

  6. Spacing in docs

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    0790f24 View commit details
    Browse the repository at this point in the history

  7. Fix tests

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    a155a44 View commit details
    Browse the repository at this point in the history

  8. Add NEWS entry for loadmodel!

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    fbc9faf View commit details
    Browse the repository at this point in the history

  9. Better docs

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    b2a2664 View commit details
    Browse the repository at this point in the history

  10. Refactor loadmodel! to use a custom recursion instead of fmap. Ad… 

    …d more tests.
    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    a6cdfdd View commit details
    Browse the repository at this point in the history

  11. Add better support for loadmodel! w/ tied parameters and address so… 

    …me other review comments
    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    29662b2 View commit details
    Browse the repository at this point in the history

  12. Combine _bool_tie_check and _tie_check.

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    c831955 View commit details
    Browse the repository at this point in the history

  13. Remove _parent

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    0d55c00 View commit details
    Browse the repository at this point in the history

  14. Apply suggestions from code review 

    Co-authored-by: Michael Abbott <32575566+mcabbott@users.noreply.github.com>
    @darsnack @mcabbott
    darsnack and mcabbott committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    3c82471 View commit details
    Browse the repository at this point in the history

  15. Clarify docstrings as per review

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    9b06730 View commit details
    Browse the repository at this point in the history

  16. More clarification

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    cba299b View commit details
    Browse the repository at this point in the history

  17. Use extended help for loadmodel! docstring

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    a59f688 View commit details
    Browse the repository at this point in the history

  18. Updated docstring examples for loadmodel! to cover more cases

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d08072a View commit details
    Browse the repository at this point in the history

  19. Don't do loadleaf! docstring

    @darsnack
    darsnack committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    6b533b8 View commit details
    Browse the repository at this point in the history