-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update #592
Docs update #592
Conversation
pimsauter
commented
Feb 25, 2023
- I agree to contribute to the project under Apache 2 License.
- To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with FlexMeasures
Signed-off-by: Pim Sauter <pim.sauter@gmail.com>
Signed-off-by: Pim Sauter <pim.sauter@gmail.com>
523cb1a
to
6bff3d8
Compare
One thing that I encountered (working on a Mac now) is that port 5000 is in use by default. Could add a warning to the docs or change the port to another value, not sure what is best. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, nice improvements!
The 5000 port is the default Flask port. It being in use on Mac is of course off-putting. Can you add a warning about that in the docker-compose part of the docs? For a real solution, I agree we could simply make FlexMeasures use a more unique port number, but we'd have to discuss that in a new issue. |
Pull Request Test Coverage Report for Build 4270433543
💛 - Coveralls |
Signed-off-by: Pim Sauter <pim.sauter@gmail.com>
This is indeed a bit strange, added a note for now. |
Improve docker installation tutorial. * Add pycharm dir to gitignore Signed-off-by: Pim Sauter <pim.sauter@gmail.com> * Add docs fixes Signed-off-by: Pim Sauter <pim.sauter@gmail.com> * Add note about port 5000 on mac Signed-off-by: Pim Sauter <pim.sauter@gmail.com> --------- Signed-off-by: Pim Sauter <pim.sauter@gmail.com>