Fix #490: regression in Double/Float conversion for "untyped" deseria…

…lization
FasterXML · May 4, 2024 · 0cf7855 · 0cf7855
1 parent 2de31bf
commit 0cf7855
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/ion/src/main/java/com/fasterxml/jackson/dataformat/ion/IonParser.java b/ion/src/main/java/com/fasterxml/jackson/dataformat/ion/IonParser.java
@@ -369,6 +369,9 @@ private double _getDoubleValue() throws IOException {
     @Override
     public float getFloatValue() throws IOException {
         _verifyIsNumberToken();
+        // 04-May-2024, tatu: May seem odd but Ion really does not
+        //   expose 32-bit floats even if it MAY use them internally
+        //   for encoding. So:
         return (float) _getDoubleValue();
     }
 
@@ -472,6 +475,7 @@ public NumberType getNumberType() throws IOException
                         return NumberType.BIG_INTEGER;
                     }
                 case FLOAT:
+                    // 04-May-2024, tatu: Ion really does not expose 32-bit floats, so:
                     return NumberType.DOUBLE;
                 default:
                 }
@@ -489,7 +493,9 @@ public NumberTypeFP getNumberTypeFP() throws IOException
                 // 06-Jan-2024, tatu: Existing code maps Ion `FLOAT` into Java
                 //    `float`. But code in `IonReader` suggests `Double` might
                 //    be more accurate mapping... odd.
-                return NumberTypeFP.FLOAT32;
+                // 04-May-2024, tatu: Ion really does not expose 32-bit floats;
+                //    must expose as 64-bit here too
+                return NumberTypeFP.DOUBLE64;
             }
             if (type == IonType.DECIMAL) {
                 // 06-Jan-2024, tatu: Seems like `DECIMAL` is expected to map

diff --git a/release-notes/VERSION-2.x b/release-notes/VERSION-2.x
@@ -23,8 +23,9 @@ Active maintainers:
 #487 (ion): Don't close IonParser on EOF to be compatible with `MappingIterator`
   when source is an empty `InputStream`
  (contributed by Yoann V)
-
 #488 (ion): Upgrade `ion-java` to 1.11.7 (from 1.11.2)
+#490 (ion) ION deserialization type change from Double to Float in 2.17.0
+ (reported by Florian H)
 
 2.17.0 (12-Mar-2024)