Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding trait for GeneratorAwareExtension #165

Merged
merged 4 commits into from
Dec 22, 2020
Merged

Adding trait for GeneratorAwareExtension #165

merged 4 commits into from
Dec 22, 2020

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Dec 20, 2020

Blocked by #154

@localheinz localheinz added the enhancement New feature or request label Dec 21, 2020
@localheinz localheinz assigned localheinz and unassigned Nyholm Dec 22, 2020
@localheinz localheinz assigned pimjansen and unassigned localheinz Dec 22, 2020
@localheinz
Copy link
Member

@Nyholm @pimjansen

I removed an unnecessary property initialization and added a test - do you want to take a look?

Nyholm
Nyholm commented Dec 22, 2020
View reviewed changes
Copy link
Member Author

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Thank you

👍

@localheinz localheinz merged commit 1dad76c into FakerPHP:main Dec 22, 2020
@localheinz
Copy link
Member

Thank you, @Nyholm!

@Nyholm
Copy link
Member Author

Nyholm commented Dec 22, 2020

Thank you for improving the PR and for merging

@Nyholm Nyholm deleted the GeneratorAwareTrait branch December 22, 2020 10:10
krsriq pushed a commit to krsriq/Faker that referenced this pull request Jan 7, 2021
@Nyholm @localheinz @krsriq
Adding trait for GeneratorAwareExtension (FakerPHP#165)
f26cd19 
* Adding trait for GeneratorAwareExtension

* Fixes

* Fix: Remove unnecessary initialization

* Fix: Add test

Co-authored-by: Andreas Möller <am@localheinz.com>
@localheinz localheinz mentioned this pull request Sep 5, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@localheinz localheinz localheinz approved these changes

@pimjansen pimjansen Awaiting requested review from pimjansen

Assignees

@pimjansen pimjansen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nyholm @localheinz @pimjansen