Update loom #1060
Merged
Update loom #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we need to swap JSR compileOnly dep (in game rules) to jetbrains or is jetbrains auto included and we just need to drop JSR there. |
|
Good call, all refrences to JSR should be gone with this. Will update the PR |
sfPlayer1
approved these changes
Sep 4, 2020
i509VCB
approved these changes
Sep 4, 2020
|
Don't merge just yet, this is apparenly still broken as its crashing in prod. |
|
This seems to now be working correctally. After merging you may need to run with |
i509VCB
pushed a commit
to FabLabsMC/fabric
that referenced
this pull request
Sep 13, 2020
You may need to run `--refresh-dependencies` if you have odd issues. Please ask if you need help.
modmuss50
added a commit
that referenced
this pull request
Sep 18, 2020
You may need to run `--refresh-dependencies` if you have odd issues. Please ask if you need help.
modmuss50
added a commit
that referenced
this pull request
Oct 5, 2020
You may need to run `--refresh-dependencies` if you have odd issues. Please ask if you need help.
ThalusA
pushed a commit
to ThalusA/fabric
that referenced
this pull request
May 31, 2022
You may need to run `--refresh-dependencies` if you have odd issues. Please ask if you need help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a lot faster.
Needs a little bit more testing before id by happy using it to build. This will allow the use of the jetbrains annotations as well. (Out of scope for this PR)