Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two regression tests by increasing n_error_buf #1218

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

marchdf
Copy link
Contributor

@marchdf marchdf commented Aug 28, 2024

Summary

This fixes the FPEs that are showing up in debug builds of inflow_godunov_amr and inflow_bds_amr by making "good grids". You can see the failures here: https://my.cdash.org/tests/195392812

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional information

Comparison of the grids for inflow_godunov_amr. This PR (left), main (right)

You can see that there are only 2 cells on level 1 between level 0 and level 2.

Screenshot 2024-08-28 at 8 41 13 AM

@marchdf
Copy link
Contributor Author

marchdf commented Aug 28, 2024

The following tests FAILED:
         78 - inflow_godunov_amr (Failed)
         79 - inflow_bds_amr (Failed)

which is expected, they need to be reblessed.

@marchdf marchdf marked this pull request as ready for review August 28, 2024 14:43
@jrood-nrel jrood-nrel merged commit dcdaf70 into Exawind:main Aug 28, 2024
14 checks passed
@marchdf marchdf deleted the fix-tests branch August 28, 2024 15:27
moprak-nrel pushed a commit to moprak-nrel/amr-wind that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants