Add non-nix installation instructions #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveitser
force-pushed
the
ma/non-nix-install
branch
from
f7052a8
to
6b3ae2a
Compare
sveitser
requested review from
nomaxg,
philippecamacho,
ImJeremyHe and
jbearer
as code owners
|
Since I removed the PR CI trigger, the latest run is here. |
jbearer
approved these changes
Nov 17, 2023
Comment on lines
+24
to
+27
| grep '^ ' doc/ubuntu.md \ | ||
| | sed 's/^ //' \ | ||
| | sed 's/^sudo //' \ | ||
| | bash -exo pipefail |
|
Thank you for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Room for improvement: currently the toolchain file is not read by nix so there is potentital for the toolchain file to go out of sync. It would be easy to do that however, in that case
nix flake updatewon't update rust anymore. I read dependabot doesn't handle toolchain files so we'd have to manually update it. We could also use "stable" instead of a specific version tag.