fix plist parsing for skip files #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyorb
added
bugfix 🔨
analyzer 📈
gyorb
force-pushed
the
fix-plist-skip
branch
2 times, most recently
from
8980c42
to
4d3483a
Compare
codechecker_common/plist_parser.py
Outdated
| @@ -97,7 +97,7 @@ def parse(self, fileobj): | |||
| return self.root | |||
|
|
|||
|
|
|||
| def read_plist(path): | |||
| def load_plist(plist_file): | |||
There was a problem hiding this comment.
@gyorb The argument of this function is not a plist file. It is the content of a plist file.
Also this function will not load the given plist file, it will only parse it.
There was a problem hiding this comment.
Actually it is a file object and not the file content, I've made some renaming to make it more explicit.
gyorb
force-pushed
the
fix-plist-skip
branch
2 times, most recently
from
0c8d4fa
to
7fe4a78
Compare
The introduced new plist xml parsing method with lxml was not introduced for the use cases where a skip file was used. In case of a skip file the report plist files can be rewritten (the reports based on the skip file content) are removed. Previous tests did not fail because a second skip is done at the server side during storage and the server skip tests worked on the stored reports.
gyorb
changed the title
csordasmarton
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intoduced new plist xml parsing method with lxml
was not introduced for the use cases where the a skip file
was used. In case of a skip file the report plist files
can be rewritten (the reports based on the skip file content)
are removed.
Previous tests did not fail because a second skip is done
at the server side during storage and the server skip tests
worked on the stored reports.