Skip to content

Commit

Permalink
Merged PR 2896: Correct table and text formatting errors
Browse files Browse the repository at this point in the history
Correct table and text formatting errors
  • Loading branch information
mikeytdisco committed Oct 16, 2020
1 parent 39f4f50 commit 3dd7fd6
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 11 deletions.
4 changes: 2 additions & 2 deletions DfciPkg/Docs/Internals/DfciInternals.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@ Sample permission packet:

## Settings Packet Formats

![Setting packet signature](Images/SettingsPacket.jpg)
![Setting packet signature](Images/SettingsPacket_mu.jpg)

![Setting packet signature](Images/DataPacketSignature.jpg)
![Setting packet signature](Images/DataPacketSignature_mu.jpg)

Sample settings payload:

Expand Down
14 changes: 10 additions & 4 deletions DfciPkg/UnitTests/DfciTests/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,15 @@ See the Platforms\SimpleFTDI\ folder.

Copy the files needed for the DUT.
There is a script to help you do this.
With a removable device at drive letter D for example, issue the command **DeviceUnderTest\CollectFilesForDut.cmd D:\DfciSetup**.
This will create a directory on the USB key named DfciSetup with the required files for setting up the remote server.
Mount the USB device on the DUT and run the **SetupDUT.cmd**.
For example, with a removable device mounted at drive D:, issue the command:

**DeviceUnderTest\CollectFilesForDut.cmd D:\DfciSetup**

This will create a directory on the USB key named **DfciSetup** with the required files for setting up the remote server.
Mount the removable device on the DUT and run:

**SetupDUT.cmd**

This will download and install Python 3.7.4, robotframework, robotremoteserver, and pypiwin32.
In addition, the SetupDUT command will update the firewall for the robot framework testing, and a make a couple of configuration changes to Windows for a better test experience.

Expand All @@ -56,7 +62,7 @@ Copy the DfciTests directory, including all of the contents of the subdirectorie
Table of DFCI Test case collections:

| Test Case Collection | Description of Test Case |
| ----- | ----- | ----- |
| ----- | ----- |
| DFCI_CertChainingTest | Verifies that a ZeroTouch enroll actually prompts for authorization to Enroll when the enroll package is not signed by the proper key.|
| DFCI_InitialState | Verifies that the firmware indicates support for DFCI and that the system is not already enrolled into DFCI. |
| DFCI_InTuneBadUpdate | Tries to apply a settings package signed with the wrong key |
Expand Down
2 changes: 1 addition & 1 deletion MsCorePkg/DebugFileLoggerII/Dxe/DebugFileLogger.c
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ DebugFileLoggerDxeEntry (
}

//
// Step 5. Register for PostReadytoBoot Notifications.
// Step 5. Register for PostReadyToBoot Notifications.
//
Status = ProcessPostReadyToBootRegistration ();

Expand Down
2 changes: 1 addition & 1 deletion MsCorePkg/Library/TpmSgNvIndexLib/TpmSgNvIndexLib.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ DefineSgTpmNVIndexforOS (
// 0x420F0404 - Attributes
NvData.nvPublic.attributes.TPMA_NV_POLICYWRITE = 1; // BIT2
NvData.nvPublic.attributes.TPMA_NV_POLICY_DELETE = 1; // BIT10
NvData.nvPublic.attributes.TPMA_NV_PPREAD = 1; // BIT16
NvData.nvPublic.attributes.TPMA_NV_PPREAD = 1; // BIT16 // spell-checker: disable-line
NvData.nvPublic.attributes.TPMA_NV_OWNERREAD = 1; // BIT17
NvData.nvPublic.attributes.TPMA_NV_AUTHREAD = 1; // BIT18
NvData.nvPublic.attributes.TPMA_NV_POLICYREAD = 1; // BIT19
Expand Down
4 changes: 1 addition & 3 deletions MsCorePkg/MsCorePkg.ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"SecurityPkg/SecurityPkg.dec"
],
"AcceptableDependencies-HOST_APPLICATION":[ # for host based unit tests

],
"AcceptableDependencies-UEFI_APPLICATION": [
"UnitTestFrameworkPkg/UnitTestFrameworkPkg.dec"
Expand Down Expand Up @@ -56,8 +56,6 @@

## options defined ci/Plugin/SpellCheck
"SpellCheck": {
# Fails test but run in AuditOnly mode to collect log
"AuditOnly": true,
"IgnoreStandardPaths": [ # Standard Plugin defined paths that should be ignore
],
"IgnoreFiles": [ # use gitignore syntax to ignore errors in matching files
Expand Down

0 comments on commit 3dd7fd6

Please sign in to comment.