Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos sdk 47 8 #10

Merged
merged 61 commits into from
Mar 26, 2024
Merged

Cosmos sdk 47 8 #10

merged 61 commits into from
Mar 26, 2024

Conversation

Pirrozho4ek
Copy link

No description provided.

@@ -196,7 +196,7 @@
args.chainID, _ = cmd.Flags().GetString(flags.FlagChainID)
args.minGasPrices, _ = cmd.Flags().GetString(sdkserver.FlagMinGasPrices)
args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack. Warning test

Returned error is not propagated up the stack.
@@ -161,7 +161,7 @@
args.nodeDaemonHome, _ = cmd.Flags().GetString(flagNodeDaemonHome)
args.startingIPAddress, _ = cmd.Flags().GetString(flagStartingIPAddress)
args.numValidators, _ = cmd.Flags().GetInt(flagNumValidators)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyAlgorithm)
args.algo, _ = cmd.Flags().GetString(flags.FlagKeyType)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack. Warning test

Returned error is not propagated up the stack.
@@ -75,7 +76,7 @@
interactive, _ := cmd.Flags().GetBool(flagInteractive)
noBackup, _ := cmd.Flags().GetBool(flagNoBackup)
useLedger, _ := cmd.Flags().GetBool(flags.FlagUseLedger)
algoStr, _ := cmd.Flags().GetString(flags.FlagKeyAlgorithm)
algoStr, _ := cmd.Flags().GetString(flags.FlagKeyType)

Check warning

Code scanning / gosec

Returned error is not propagated up the stack. Warning

Returned error is not propagated up the stack.
@Pirrozho4ek Pirrozho4ek changed the base branch from audit to main March 26, 2024 14:16
if (
type === ContentType.FormData &&
body &&
body !== null &&

Check warning

Code scanning / CodeQL

Comparison between inconvertible types Warning

Variable 'body' cannot be of type null, but it is compared to
an expression
of type null.
@Pirrozho4ek Pirrozho4ek changed the base branch from main to main_cosmos_update March 26, 2024 15:03
@yerasyla yerasyla merged commit 9a7d1cc into main_cosmos_update Mar 26, 2024
20 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants