Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Done Compatible AZEROTHCORE. #271

Merged
merged 9 commits into from
Jun 6, 2018

Conversation

AyaseCore
Copy link
Contributor

Compatible AZEROTHCORE.
It has been redone.
Remove all defined TRINITY.
I used the predefined AZEROTHCORE.
It didn't break anything.
It support cmangos mangos trinity and azeroth.

Something like this:

# ifndef TRINITY
aaa
#else
bbb
# endif

I had to change it:

# ifdef TRINITY
bbb
#elif AZEROTHCORE
ccc
#else
aaa
# endif

Please check it if you have time. @Rochet2

@AyaseCore
Copy link
Contributor Author

Thank you for your work. @Rochet2

@Rochet2
Copy link
Member

Rochet2 commented May 22, 2018

The cmake changes are missing? Or is that intended?
I mean, is it intended that only the module has a cmake file and Eluna will not have one for the azerothcore setup?

@AyaseCore
Copy link
Contributor Author

@Rochet2
The cmakelist.txt in eluna is not used.
I use the hooks of the module to contain the files of eluna.
By default, eluna is disabled in the azerothcore.
If the user needs to enable eluna, just place the eluna module in the modules folder.Update the eluna in the submodule.cmake again.the install is done.
https://github.com/AyaseCore/mod-LuaEngine

@Rochet2 Rochet2 merged commit 9b5499d into ElunaLuaEngine:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants