Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions should validate access level on registration #8337

Closed
mrclay opened this issue May 20, 2015 · 3 comments
Closed

Actions should validate access level on registration #8337

mrclay opened this issue May 20, 2015 · 3 comments
Labels
dev usability

Comments

@mrclay
Copy link
Member

mrclay commented May 20, 2015

E.g. the level "Admin" is silently treated as "logged_in".
@mrclay
Copy link
Member Author

mrclay commented May 20, 2015

Probably best for unrecognized values to be treated as "admin"

@hypeJunction
Copy link
Contributor

It would be nice to have constants for that to avoid typos

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue May 31, 2015
@mrclay
fix(actions): Misspelled action levels no longer treated as logged_in.
391834b 
Instead we now log an error and set the level to “admin”

Fixes Elgg#8337
@mrclay mrclay mentioned this issue May 31, 2015
Merged
@mrclay
Copy link
Member Author

mrclay commented May 31, 2015

PR #8398

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 1, 2015
@mrclay
fix(actions): Misspelled action levels no longer treated as logged_in.
d936549 
Instead we now log an error and set the level to “admin”

Fixes Elgg#8337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev usability
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrclay @hypeJunction