Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow modifying $vars before view rendering #7736

Closed
mrclay opened this issue Dec 29, 2014 · 1 comment
Closed

Allow modifying $vars before view rendering #7736

mrclay opened this issue Dec 29, 2014 · 1 comment

Comments

@mrclay
Copy link
Member

mrclay commented Dec 29, 2014

This seems to me the most powerful flavor of view extension and trivial to add with a "view_vars" hook.

This would make it trivial to configure views globally without overriding. E.g. The hook could be used to set $vars['limit'] in the page/elements/comments view to control comment pagination.
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jan 26, 2015
@mrclay
WIP feature(views): plugin hooks can modify view $vars
63084ab 
Fixes Elgg#7736
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jan 28, 2015
@mrclay
WIP feature(views): plugin hooks can modify view $vars
52826db 
Fixes Elgg#7736
mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Feb 5, 2015
@mrclay
feature(views): plugin hooks can modify view $vars
d493bf9 
Fixes Elgg#7736
@mrclay mrclay mentioned this issue Feb 5, 2015
Merged
@jdalsem
Copy link
Member

jdalsem commented Feb 6, 2015

Closing as PR is merged

@jdalsem jdalsem closed this as completed Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrclay @jdalsem