Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Remember me" table upgrade is slow #6204

Closed
Srokap opened this issue Nov 5, 2013 · 3 comments
Closed

"Remember me" table upgrade is slow #6204

Srokap opened this issue Nov 5, 2013 · 3 comments
Labels
important performance
Milestone
Elgg 1.9.0

Comments

@Srokap
Copy link
Contributor

Srokap commented Nov 5, 2013

On community page data it took way over 1h to run. We need to split it into steps, see #5842

It seemed to hit mysql a lot. Dropping DISTINCT may be beneficial here. See #5241
@mrclay
Copy link
Member

mrclay commented Nov 5, 2013

Can't this be done with one SELECT INTO query?

@Srokap
Copy link
Contributor Author

Srokap commented Nov 5, 2013

Looks like it should be doable.

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jan 15, 2014
@mrclay
Fixes Elgg#6204: Fast building of remember me table
9a6ceef
@mrclay
Copy link
Member

mrclay commented Jan 15, 2014

PR #6330

@mrclay mrclay closed this as completed in 52f9fa4 Feb 11, 2014
brettp added a commit that referenced this issue Feb 11, 2014
@brettp
Merge pull request #6330 from mrclay/6204
f32e2b8 
perf(upgrade): speeds up migrating remember me codes

The Remember me cookie implementation has been improved by moving codes
to a separate table. This performs that migration in one query.

Fixes #6204
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
important performance
Milestone
Elgg 1.9.0
Development

No branches or pull requests
2 participants
@mrclay @Srokap