Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing setpoint when program running changes the actual "comfort setting" #6

Closed
jimboca opened this issue Dec 9, 2018 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jimboca
Copy link
Collaborator

jimboca commented Dec 9, 2018

Changing setpoint when program running changes the actual "comfort setting" - so this is saved permanently moving forward

@jimboca jimboca mentioned this issue Dec 9, 2018
@jimboca jimboca self-assigned this Dec 11, 2018
@jimboca jimboca added the bug Something isn't working label Dec 11, 2018
@jimboca jimboca added this to the 2.0.7 milestone Dec 11, 2018
@jimboca
Copy link
Collaborator Author

jimboca commented Dec 11, 2018

@Einstein42 Looking at the code, it seems this was intentional? It changes the setpoint for the currently running program. This doesn't seem correct? If the user is changing a setpoint then it's a temporary change, not a permanent one for the program?

The current code changes setpoint like this: https://www.ecobee.com/home/developer/api/examples/ex11.shtml

The user request is that it only modifies the current temperature, like so:
https://www.ecobee.com/home/developer/api/examples/ex5.shtml

But then we will have to track that we added the hold, and if they change it again we remove that hold and add the new one?

@Einstein42
Copy link
Owner

Good question, probably why I didn't know what to do there.

jimboca added a commit that referenced this issue Dec 13, 2018
@jimboca jimboca closed this as completed Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants