feat: better node metrics chart #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ehco1996
added a commit
that referenced
this pull request
Sep 3, 2024
This commit adds support for refreshing node and rule metrics in the `cmgrImpl` struct. The `QueryNodeMetrics` and `QueryRuleMetrics` methods now have an additional `refresh` parameter, which when set to `true`, refreshes the cache and retrieves the latest data. The `QueryNodeMetrics` method now checks if `refresh` is `true` and updates the cache with the latest node metrics if needed. It then calls the `QueryNodeMetric` method to retrieve the requested metrics. The `QueryRuleMetrics` method follows a similar pattern, refreshing the cache with the latest rule metrics if `refresh` is `true`, and then calling the `QueryRuleMetric` method to retrieve the metrics. This change improves the accuracy of the metrics data by allowing users to retrieve the latest metrics when needed. Refactor code to use GetAddrHost instead of ToString for Node struct save work save save work support parse rule metric refine metrics label feat: better node metrics chart (#370) chore: Update dependencies and refactor transporter package for improved performance and readability (#369) chore: use cgo-free sqlite driver feat: add timepicker to dashboard (#367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.