Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(internal/constant): add RelayType #348

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

ioogle
Copy link
Contributor

@ioogle ioogle commented Jun 22, 2024

Issue: #345

@ioogle
Copy link
Contributor Author

ioogle commented Jun 22, 2024

Since relay types can be specified via the command line, the validateType() function cannot be eliminated. However, it is best practice to use a self-defined type.

@Ehco1996
Copy link
Owner

@ioogle thanks for your pr, but ci failed, could your please check and fix these errors?

Error: internal/transporter/ws.go:35:25: cannot use cfg.TransportType (variable of type "github.com/Ehco1996/ehco/internal/constant".RelayType) as string value in argument to zap.S().Named (typecheck)

By the way, you can execute make lint and make test commands to check if your patch can pass the CI tests

Copy link
Owner

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ehco1996 Ehco1996 merged commit 0eb6d65 into Ehco1996:master Jun 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants