Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make location button space for more wide, so it's easy to click on smaller screen d… #1842

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

incomingflyingbrick
Copy link

Hi, I changed location button spacing a little bit, no logic change.
Sometime i found out that it's very hard to click the right button, because all three button on the left are too close together. (My Location Button, Drone location Button, Sliding Panel Button)

@gmorph
Copy link

gmorph commented Oct 26, 2017

The build.gradle change ideally should be removed from this PR.

@preet90
Copy link
Contributor

preet90 commented Oct 27, 2017

@incomingflyingbrick The bottom margin was updated from 5dp to 6dp in the API >= 21. I believe changing just 1dp does not make any noticeable difference.

I think it is easier for user to click buttons if we update from -16dp to -6dp in "values/styles.xml" and update 5dp to 15dp in "values-v21/styles.xml" file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants