Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt to react-scripts@2.1.2 #6

Merged

Conversation

zhuzhuaicoding
Copy link

fix sass loaders not found

@ndbroadbent ndbroadbent merged commit ef1f813 into DocSpring:master Dec 27, 2018
@ndbroadbent
Copy link
Member

Thanks! I'm testing this with craco 3.2.3 and react-scripts 2.1.2, but getting lots of test failures. Looks like there were lots of changes that affect the webpack config: dilanx/craco#61

And here's a PR that fixes the issue - dilanx/craco#62

Once that is merged and craco releases a new version, I'll update craco-less to support react-scripts 2.1.2.

In the meantime, please downgrade your react-scripts version to 2.1.1.

Thanks!

@Delphier
Copy link

@ndbroadbent hello, craco 3.3.1 released 😁

@ndbroadbent
Copy link
Member

Woohoo! I've pushed version 1.6.0 of craco-less with support for these versions:

    "@craco/craco": "^3.3.1",
    "react-scripts": "^2.1.2"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants