Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate cli to typescript #2612

Merged
merged 10 commits into from
Mar 16, 2021
Merged

chore: migrate cli to typescript #2612

merged 10 commits into from
Mar 16, 2021

Conversation

septs
Copy link
Contributor

@septs septs commented Mar 16, 2021

No description provided.

@septs septs changed the title chore: rename cli-dev-build to cli chore: migrate cli to typescript Mar 16, 2021
@septs septs requested a review from Jack-Works March 16, 2021 13:49
@septs septs requested a review from Jack-Works March 16, 2021 14:13
Jack-Works
Jack-Works reviewed Mar 16, 2021
View reviewed changes
packages/cli/build/typescript.ts
}
runCli({ config, watch: true }, console.error)
// start a one-time "tsc -b" or parallel "tsc -b -w"
return spawn('npx', ['tsc', '-b', '-w'], options)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript might die. Would you like to add code to restart tsc when it dies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yourself solve fix this problem?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well not urgent.

@septs septs merged commit 9d690ec into master Mar 16, 2021
@septs septs deleted the septs/refactor-cli branch March 16, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Works Jack-Works Jack-Works approved these changes

@guanbinrui guanbinrui Awaiting requested review from guanbinrui

@jk234ert jk234ert Awaiting requested review from jk234ert

@zhouhanseng zhouhanseng Awaiting requested review from zhouhanseng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@septs @Jack-Works