Add info tags to define PVI structure from controllers #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 79.16% 80.98% +1.81%
==========================================
Files 22 22
Lines 835 857 +22
==========================================
+ Hits 661 694 +33
+ Misses 174 163 -11 ☔ View full report in Codecov by Sentry. |
GDYendell
force-pushed
the
pvi-structure
branch
2 times, most recently
from
e46b028
to
5273e57
Compare
coretl
reviewed
Aug 21, 2024
GDYendell
force-pushed
the
pvi-structure
branch
4 times, most recently
from
5c4f119
to
656f7da
Compare
Refactor helper functions to preserve PV prefix until later so that PVI PV can use it. Remove call to SetDeviceName and construct full PVs when creating records. Add call to create info tags on all records as they are created to add them to the PVI of the controller. Add call to add sub controller PVI to parent PVI
GDYendell
force-pushed
the
pvi-structure
branch
from
656f7da
to
8b319a4
Compare
Add a fixture to run an EPICS IOC in a subprocess. Add a test that queries the PVI PV of an IOC and verifies the structure is as expected.
GDYendell
force-pushed
the
pvi-structure
branch
from
8b319a4
to
1ea93a7
Compare
coretl
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.