Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter disk, io & network metrics by device #615

Merged
merged 15 commits into from
Aug 20, 2013
Merged

Filter disk, io & network metrics by device #615

merged 15 commits into from
Aug 20, 2013

Conversation

clutchski
Copy link
Contributor

This pull request allows us to configure a device_blacklist_re in datadog.conf. This will be checked against all disk & io devices so we can easily filter out fake devices.

This pull request contains a few things:

  • device filtering on disk metrics
  • device filtering on io metrics
  • device filtering on network metrics
  • run unit disk metric parsing tests on all platforms (since the parsing code is not os specific)
  • removes a bunch of base exceptions
  • random little cleanups
  • added a platform library for cleaner platform detection

@remh @elijahandrews @alq666 can you review?

@conorbranagan
Copy link
Member

Should we move this to a checks.d as we did with the network metrics so we can configure the blacklist in there instead of continuing to crowd datadog.conf? Then we could add a list of specific devices to skip and/or multiple regex expressions.

# Optionally completely ignore any network interface
# matching the given regex:
#excluded_interface_re: my-network-interface.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth noting that this file will be overwritten when the Agent is updated?

On a related note, should we consider making this file a 'configuration file' as far as packaging is concerned? Here is how it would be handled in a Debian package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the right solution is to make system checks have default behaviour without yaml and optionally allow people to override.

This will:

  • prevent us from blocking installers with questions like "do you want to overwrite this config?"
  • let system checks run without manual work for new users
  • allows optional config

Thoughts?

@conorbranagan @elijahandrews @alq666

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed this morning, this is what I think we should do: #620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants