Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a config option for pup to allow setting the bound network interface #394

Merged
merged 2 commits into from
Mar 7, 2013

Conversation

shamada-kuuluu
Copy link
Contributor

When having multiple network interfaces in a server, it can be necessary to be able to set which interface to bind to.
In my case, just binding to all interfaces was not an option.

This simple update to pup allows setting this. (Example config file is updated as well)

Added config option to allow pup to bind to a specific interface.
Update config to show how to set bound interface for pup.
@shamada-kuuluu
Copy link
Contributor Author

I am pretty sure, that the travis build failed due to other problems not connected with my changes.

@alq666
Copy link
Member

alq666 commented Mar 5, 2013

There's more than just pup listening to an interface (dogstatsd among others) so we'd like to have a uniform way to configure which interface it binds to. Is the interface parameter meant to be an IP address?

@shamada-kuuluu
Copy link
Contributor Author

Of course it makes sense to add this for the other services as well, but I focused on pup. Nevertheless I'd prefer an option for each service. That way you have fine grained control over what's listening where.
The interface parameter is usually an ip address, but it should work with a hostname as well (after all, the default is the hostname 'localhost' and not 127.0.0.1).

remh added a commit that referenced this pull request Mar 7, 2013
Added a config option for pup to allow setting the bound network interface
@remh remh merged commit 80cdc29 into DataDog:master Mar 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants