fix #627 #639
Merged
fix #627 #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attempt to fix a minor PVS Studio warning which claims that passing a value by copy is worse for performance than a value by reference, which, given that the value is 16 bytes long, is already silly just from the start, but is even more so in this case as the function is short designed to be inlined by the compiler anyway. Made the inlining objective more explicit, in an attempt to silence the static analyzer objection. This is a blind fix, as I don't have PVS Studio to check.
|
Rescan in progress. |
|
Confirmed good! pvs-analysis-report.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to fix a minor PVS Studio warning
which claims that passing a value by copy is worse for performance than a value by reference.
Given that the value is 16 bytes long, the claim is quite debatable, if not already silly from the start,
but it is even more so in this case because the function is very short and designed to be inlined by the compiler anyway.
Made the inlining objective more explicit, in an attempt to silence the static analyzer objection.
This is a blind fix, as I don't have PVS Studio to check.
fix #627 (hopefully)