Fix incorrect error logged when a newly imported block has an invalid payload #5961
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
When a block with an invalid payload was imported while the EL was in sync, Teku failed to find the latestValidHash because it wasn't checking the direct parent in this case (the code was originally only dealing with blocks that were imported optimistically and then later found to be invalid).
Teku's behaviour was correct (and there was even a test for it) but in incorrectly logged:
Now it does not.
Documentation
doc-change-required
label to this PR if updates are required.Changelog