Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect error logged when a newly imported block has an invalid payload #5961

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

ajsutton
Copy link
Contributor

PR Description

When a block with an invalid payload was imported while the EL was in sync, Teku failed to find the latestValidHash because it wasn't checking the direct parent in this case (the code was originally only dealing with blocks that were imported optimistically and then later found to be invalid).

Teku's behaviour was correct (and there was even a test for it) but in incorrectly logged:

2022-07-21 10:53:00.508 ERROR - Could not find latest valid execution payload hash (0xfa87aa1b3ee36c763fb5b083aa3fed49fd037371ffc4949b03f894fcf5c3c099) in the non-finalized chain. Optimistic sync may have finalized an invalid transition block.

Now it does not.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsutton ajsutton enabled auto-merge (squash) July 21, 2022 23:14
@ajsutton ajsutton merged commit 3d4bdbb into Consensys:master Jul 21, 2022
@ajsutton ajsutton deleted the remove-finalized-error branch July 21, 2022 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants