Suppress multiple attestation gossiping failures logs #5948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbenr
commented
Jul 19, 2022
| "Failed to publish attestation(s) for slot {} and committee index {} because the message has already been seen", | ||
| lastErroredSlot, | ||
| lastErroredCommitteeIndex); | ||
| } else if (Throwables.getRootCause(error) instanceof NoPeersForOutboundMessageException) { |
There was a problem hiding this comment.
I could move the synchronized section here, after the debug for the "already seen", to reduce overhead.
ajsutton
approved these changes
Jul 19, 2022
...ng/eth2/src/main/java/tech/pegasys/teku/networking/eth2/gossip/AttestationGossipManager.java
Outdated
Show resolved
Hide resolved
...ng/eth2/src/main/java/tech/pegasys/teku/networking/eth2/gossip/AttestationGossipManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt to improve log bursts.
The idea is to log failures only the first of a burst of attestations with same
Slot,IndexCommitteeand rootCause.The synchronized method should not add any overhead in normal operation since it only applies to failure handling.
fixes #5867
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog