Implement ExecutionPayload processing #4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the spec, assumes the execution engine is available separately so while this is enough to get reference tests passing we will need an actual ExecutionEngineChannel implementation before it works in the real world. Also hasn't implemented optimistic sync which will need to be done separately.
tbenr
reviewed
Nov 9, 2021
| final ExecutionPayload executionPayload, | ||
| final ExecutionEngineChannel executionEngine) | ||
| throws BlockProcessingException { | ||
| throw new UnsupportedOperationException("No ExecutionPayload in phase0"); |
There was a problem hiding this comment.
I knew I'd forget to change that....
tbenr
approved these changes
Nov 9, 2021
| @@ -40,4 +41,8 @@ public boolean isMergeBlock(final BeaconState genericState, final BeaconBlock bl | |||
| public boolean isExecutionEnabled(final BeaconState genericState, final BeaconBlock block) { | |||
| return isMergeBlock(genericState, block) || isMergeComplete(genericState); | |||
| } | |||
|
|
|||
| public UInt64 computeTimestampAtSlot(final BeaconState state, final UInt64 slot) { | |||
There was a problem hiding this comment.
I left this as state matching the spec because we didn't need to have a BeaconStateMerge version and thus didn't need to differentiate the names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implements the spec version of execution payload processing during block processing.
As per the spec, assumes the execution engine is available separately so while this is enough to get reference tests passing we will need an actual ExecutionEngineChannel implementation before it works in the real world. Currently everything is passing in
ExecutionEngineChannel.NOOP.Also hasn't implemented optimistic sync which will need to be done separately.
Documentation
documentationlabel to this PR if updates are required.Changelog