Upgrade discovery #4185
Merged
Upgrade discovery #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Updates discovery to 0.4.8 which is a significant change to how nodes are stored internally.
Node storage is now entirely based on the KBuckets ensuring that there is an upper bound on the number of nodes stored in memory.
Searching for new nodes now returns the list of nodes which are considered for connection even if they don't fit in the KBuckets.
Recursive search for peers also continuously selects the closest peers to the target, resulting in more effective searches.
Added metric to report the number of tracked live nodes in the discovery buckets.
Fixed Issue(s)
fixes Consensys/discovery#103
Documentation
documentationlabel to this PR if updates are required.Changelog