Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Simplify Spec construction #3848

Merged
merged 9 commits into from
Apr 12, 2021
Merged

[Refactor] Simplify Spec construction #3848

merged 9 commits into from
Apr 12, 2021

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Apr 12, 2021 •
edited
Loading

PR Description

Simplify construction of Spec in production:

  • Created a limited SpecFactory interface for use in production
    • This lays the groundwork for switching between Phase0-only implementations, and fork-aware implementations with Altair support
  • Delete SpecConfiguration since it only held a single instance var: specConfig
  • Use TestSpecFactory across tests

Fixed Issue(s)

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

rolfyone
rolfyone approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbaxter mbaxter enabled auto-merge (squash) April 12, 2021 20:28
@mbaxter mbaxter merged commit 1771fba into Consensys:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbaxter @rolfyone