Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to overwrite the $choices-z-index variable #1034

Merged
merged 1 commit into from
Jul 9, 2022
Merged

Allow to overwrite the $choices-z-index variable #1034

merged 1 commit into from
Jul 9, 2022

Conversation

johannlejeune
Copy link
Contributor

Description

#794 introduced a new SCSS variable for configuring the z-index, but it didn't set the !default flag, making it impossible to overwrite in external files.

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

#794 introduced a new SCSS variable for configuring the z-index, but it didn't set the `!default` flag, making it impossible to overwrite in external files.
@johannlejeune johannlejeune changed the title Allow to overwrite the $choices-z-index variable Allow to overwrite the $choices-z-index variable May 4, 2022
@aaronjchristian
Copy link

Yep this looks good to me!

@mtriff mtriff merged commit cbbdbda into Choices-js:master Jul 9, 2022
@johannlejeune johannlejeune deleted the patch-1 branch July 9, 2022 14:39
@johannlejeune johannlejeune restored the patch-1 branch July 9, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants