Merge pull request #3 from ChaosLabsInc/kill-process-new

Kill process on exit
ChaosLabsInc · Jul 27, 2023 · 6814a43 · 6814a43
2 parents 7706a08 + b08631b
commit 6814a43
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/classes/main-base.ts b/src/classes/main-base.ts
@@ -23,7 +23,7 @@ export default (
           await childProcessor.start(msg.job);
           break;
         case ChildCommand.Stop:
-          break;
+          process.exit(0);
       }
     } catch (err) {
       console.error('Error handling child message');

diff --git a/src/classes/sandbox.ts b/src/classes/sandbox.ts
@@ -58,11 +58,9 @@ const sandbox = <T, R, N extends string>(
       child.off('message', msgHandler);
       child.off('exit', exitHandler);
 
-      if (child.exitCode !== null || /SIG.*/.test(`${child.signalCode}`)) {
-        childPool.remove(child);
-      } else {
-        childPool.release(child);
-      }
+      await childPool.kill(child).catch(err => {
+        console.error(err);
+      });
     }
   };
 };