-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI for contra-env-setup #71
Conversation
[test] |
1 similar comment
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits otherwise LGTM
Jenkinsfile
Outdated
executionID = UUID.randomUUID().toString() | ||
|
||
// Pod name to use | ||
podName = 'env-setup-' + executionID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contra-env-setup- to be explicit
Jenkinsfile
Outdated
description: 'Tag for slave image'), | ||
string(name: 'ENVSETUPTEST_TAG', | ||
defaultValue: 'stable', | ||
description: 'Tag for env-setup-test-c7 image'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contra-env-setup-
Jenkinsfile
Outdated
args: '${computer.jnlpmac} ${computer.name}', | ||
command: '', | ||
workingDir: '/workDir'), | ||
// This adds the env-setup-test-c7 container to the pod. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contra-env-setup-
Jenkinsfile
Outdated
command: '', | ||
workingDir: '/workDir'), | ||
// This adds the env-setup-test-c7 container to the pod. | ||
containerTemplate(name: 'env-setup-test-c7', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contra-env-setup-
Jenkinsfile
Outdated
// This adds the env-setup-test-c7 container to the pod. | ||
containerTemplate(name: 'env-setup-test-c7', | ||
alwaysPullImage: true, | ||
image: DOCKER_REPO_URL + '/' + OPENSHIFT_NAMESPACE + '/env-setup-test-c7:' + ENVSETUPTEST_TAG, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contra-env-setup-
Jenkinsfile
Outdated
envsetupUtils.setStageEnvVars(currentStage) | ||
|
||
// Run env-setup test | ||
pipelineUtils.executeInContainer(currentStage, "env-setup-test-c7", "/home/prepare_and_test.sh") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
contra-env-setup-
Jenkinsfile
Outdated
library identifier: 'contra-env-setup@env-setup-ci', | ||
retriever: modernSCM([$class: 'GitSCMSource', credentialsId: '', | ||
id: '25651a23-bada-49f0-8b7a-2d735623d646', | ||
remote: 'https://github.com/dirgim/contra-env-setup.git', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably want ghprb vars here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, will fix that
[test] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all of this move under the tests or test directory so it is isolated?
test/config/s2i/contra-env-setup-test-c7/contra-env-setup-test-buildconfig-template.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI for contra-env-setup implemented with a scripted Jenkins pipeline for basic CI with:
The contra-env-setup-test-c7 container image is used for testing contra-env-setup on a centos7 based system.
The testing consists of a prepare-and-test.sh script which does the following:
The test_contra_env_setup.py tests the following: