Fix: skip sending stdout on PUT /instances (cypress-io#7635)

* Fix: skip sending stdout on PUT /instances * Add comment for why we're setting stdout to null Co-authored-by: Brian Mann <brian.mann86@gmail.com> Co-authored-by: Brian Mann <brian.mann86@gmail.com>
Cekurok · Jun 15, 2020 · b20a77a · b20a77a
1 parent cf87458
commit b20a77a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/server/lib/modes/record.js b/packages/server/lib/modes/record.js
@@ -209,12 +209,11 @@ const updateInstanceStdout = (options = {}) => {
 }
 
 const updateInstance = (options = {}) => {
-  const { instanceId, results, captured, group, parallel, ciBuildId } = options
+  const { instanceId, results, group, parallel, ciBuildId } = options
   let { stats, tests, hooks, video, screenshots, reporterStats, error } = results
 
   video = Boolean(video)
   const cypressConfig = options.config
-  const stdout = captured.toString()
 
   // get rid of the path property
   screenshots = _.map(screenshots, (screenshot) => {
@@ -228,7 +227,7 @@ const updateInstance = (options = {}) => {
       error,
       video,
       hooks,
-      stdout,
+      stdout: null, // don't send stdout with the instance payload to prevent requests that are too large. stdout will later get uploaded separately anyway.
       instanceId,
       screenshots,
       reporterStats,
@@ -696,7 +695,6 @@ const createRunAndRecordSpecs = (options = {}) => {
           group,
           config,
           results,
-          captured,
           parallel,
           ciBuildId,
           instanceId,

diff --git a/packages/server/test/unit/api_spec.js b/packages/server/test/unit/api_spec.js
@@ -560,7 +560,7 @@ describe('lib/api', () => {
         screenshots: [],
         cypressConfig: {},
         reporterStats: {},
-        stdout: 'foo\nbar\nbaz',
+        stdout: null,
       }
 
       this.putProps = _.omit(this.updateProps, 'instanceId')