Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default CancellationToken for async methods #663

Closed
superware opened this issue Feb 9, 2020 · 1 comment · Fixed by #674
Closed

Default CancellationToken for async methods #663

superware opened this issue Feb 9, 2020 · 1 comment · Fixed by #674
Labels
enhancement
Milestone
v4.0.0

Comments

@superware
Copy link

I find myself passing default(CancellationToken) all over, although most of MS async implementations support a default CancellationToken parameter. Any thoughts?
@nigel-sampson
Copy link
Contributor

Sounds like a good idea.

@nigel-sampson nigel-sampson added this to the v4.0.0 milestone Feb 9, 2020
@Mrxx99 Mrxx99 mentioned this issue Feb 28, 2020
Merged
nigel-sampson added a commit that referenced this issue Mar 3, 2020
@nigel-sampson
Merge pull request #674 from Mrxx99/pr/CancellationToken
9c69650 
added default CancellationTokens to common methods (fixes #663)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

added default CancellationTokens to common methods (fixes #663) Mrxx99/Caliburn.Micro
2 participants
@nigel-sampson @superware