add new CMAKE version support and fix CI test failure #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 99.44% // Head: 99.44% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 16 16
Lines 3950 3950
=======================================
Hits 3928 3928
Misses 22 22 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
github-actions
bot
added
needs changelog
|
Any special reason this is max 3.24 and not 3.25? |
|
none, other than my local testing environment hasn't moved to 3.25 yet, so didn't have a local means of testing yet. We will probably update in next couple weeks. |
|
Okay, that's fine, just wanted to make sure there wasn't something (known) that needed fixing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for CMake 3.23 and 3.24 and fix an issue with the CMake tests