Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires and help all #530

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Requires and help all #530

merged 1 commit into from
Oct 28, 2020

Conversation

phlptp
Copy link
Collaborator

@phlptp phlptp commented Oct 22, 2020

fixes the issue of help all showing up in the required list error if requirement are not met.

Fixes Issue #527

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #530 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #530   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         3740      3745    +5     
=========================================
+ Hits          3740      3745    +5     
Impacted Files Coverage Δ
include/CLI/App.hpp 100.00% <100.00%> (ø)
include/CLI/StringTools.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97e5ebe...59d9277. Read the comment docs.

@henryiii henryiii merged commit 69674dc into CLIUtils:master Oct 28, 2020
@henryiii henryiii deleted the requires_help_all branch October 28, 2020 16:33
@henryiii henryiii added the needs changelog Hasn't been added to the changelog yet label Oct 28, 2020
@henryiii henryiii added this to the v2.0 milestone Jun 24, 2021
@henryiii henryiii removed the needs changelog Hasn't been added to the changelog yet label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants