Adding take_last #40
Merged
Adding take_last #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 100% 99.82% -0.18%
==========================================
Files 9 9
Lines 1141 1153 +12
Branches 233 235 +2
==========================================
+ Hits 1141 1151 +10
- Misses 0 2 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 1141 1153 +12
Branches 233 235 +2
=====================================
+ Hits 1141 1153 +12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
take_last, which causes the final option given to be the only one considered. So:Would set opt to two.
opt->countis still 2. This was also used to implement bool flags (on by default), which allows someone to restore the behavior seen before #38 by setting->take_last(false)and is a better/more general fix than #38 . This is a partial fix for #39 ; the other part of the fix would be giving the user more power over the failure messages.