Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang and cross-compile fixes #373

Merged
merged 2 commits into from
Dec 28, 2019
Merged

clang and cross-compile fixes #373

merged 2 commits into from
Dec 28, 2019

Conversation

kraj
Copy link
Contributor

@kraj kraj commented Dec 20, 2019

No description provided.

@kraj
Add CLANG_TIDY check
9af9af6 
Signed-off-by: Khem Raj <raj.khem@gmail.com>
@kraj
Use GNUInstallDirs instead of hard-coded path
4106da7 
Signed-off-by: Khem Raj <raj.khem@gmail.com>
@codecov
Copy link

codecov bot commented Dec 20, 2019 •
edited
Loading

Codecov Report

Merging #373 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #373   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        3398   3389    -9     
=====================================
- Hits         3398   3389    -9
Impacted Files Coverage Δ
include/CLI/App.hpp 100% <0%> (ø) ⬆️
include/CLI/ConfigFwd.hpp 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b979d3a...4106da7. Read the comment docs.

phlptp
phlptp approved these changes Dec 28, 2019
View reviewed changes
Copy link
Collaborator

@phlptp phlptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seem like good changes

@henryiii henryiii merged commit c72057d into CLIUtils:master Dec 28, 2019
@henryiii
Copy link
Collaborator

Thanks!

@henryiii henryiii added this to the v1.9 milestone Dec 31, 2019
@zadjii-msft zadjii-msft mentioned this pull request Dec 13, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phlptp phlptp phlptp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@kraj @henryiii @phlptp